[MINOR] improvement: fix typos of guava imports#9432
Merged
jerryshao merged 1 commit intobranch-1.1from Dec 10, 2025
Merged
Conversation
### What changes were proposed in this pull request? Some `Sets` in the project are pointed to the shadowed one in Glassfish, rather than original Guava. 1. Search through the project to replace all `import org.glassfish.jersey.internal.guava.Xxss` to its corresponding `com.google.common.collect.Xxxs`. 2. Add 3 `replaceRegex` actions to Spotless plugin, to ensure no similar issues in the future. ### Why are the changes needed? For sure the one from original Guava should be preferred, because shadowed classes are normally used for internal purposes of the party who package them, and are not intended to expose as a contract. Fix: No functionality issue involved. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests all passed. Plus, the implementations of two classes are identical, so in fact as long as it compiles right, we are good to go I believe. --------- Co-authored-by: wancheng.aliyun <tuohai@alibaba-inc.com>
jerryshao
deleted the
cherry-pick-branch-1.1-cf9612c4fca9492e23725d1629b789dd2f7d75b8
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some
Setsin the project are pointed to the shadowed one in Glassfish, rather than original Guava.import org.glassfish.jersey.internal.guava.Xxssto its correspondingcom.google.common.collect.Xxxs.replaceRegexactions to Spotless plugin, to ensure no similar issues in the future.Why are the changes needed?
For sure the one from original Guava should be preferred, because shadowed classes are normally used for internal purposes of the party who package them, and are not intended to expose as a contract.
Fix: No functionality issue involved.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests all passed. Plus, the implementations of two classes are identical, so in fact as long as it compiles right, we are good to go I believe.