[GROOVY-9483] Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX#1210
Merged
daniellansun merged 1 commit intoapache:masterfrom Mar 27, 2020
Merged
Conversation
If the user quits the Groovy console with unsaved changes, it asks if they want to 'Save changes?' Under Java 11, this still quits if they click 'Cancel' Looks like we need to cancel the quit event if cancel was pressed
Contributor
Author
|
Not sure why those checks are failing... Don't think it was me... 😞 |
Contributor
Author
timyates
changed the title
Contributor
|
+1
We face a weired issue on the github actions CI... |
Contributor
Author
|
Just checked it with 14.0.0-zulu, and it works as expected 🙌 |
Contributor
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya! 👋
If the user quits the Groovy console with unsaved changes, it asks if they want to 'Save changes?'
Under Java 11, this still quits if they click 'Cancel', it looks like we need to cancel the quit event if cancel was pressed
(Note: I've not done this in a long time, please let me know if I've missed a step, or not signed something)
Hope you're all keeping well!