GROOVY-9373 (part 1): rework line numbers for statements#1443
Merged
daniellansun merged 1 commit intomasterfrom Dec 16, 2020
Merged
GROOVY-9373 (part 1): rework line numbers for statements#1443daniellansun merged 1 commit intomasterfrom
daniellansun merged 1 commit intomasterfrom
Conversation
GROOVY-7647, GROOVY-9126, GROOVY-9199 "do" and "try" should not generate line numbers instructions after last source line are tied to closing brace instructions before first source line are tied to opening brace
Contributor
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GROOVY-9373
https://issues.apache.org/jira/browse/GROOVY-9199
https://issues.apache.org/jira/browse/GROOVY-9126
https://issues.apache.org/jira/browse/GROOVY-7647
"do" and "try" should not generate line numbers
instructions after last source line are tied to closing brace
instructions before first source line are tied to opening brace
Writing two
LINENUMBERinstructions in a row is an issue. Given this sequence fromgroovy.log.classgensystem property:If user sets breakpoint on line 8 of source, debugger will not stop because it associates line 7 with whatever instructions come next. One example of this is
try {on line 7 and some statement on line 8 (see GROOVY-9199).