GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th… #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Let's wait for the test result: |
Contributor
|
The test result is green ;-) |
pbielicki
reviewed
Apr 10, 2021
src/test/groovy/StringTest.groovy
Outdated
| //GROOVY-10024 | ||
| def s1 = $/abc\/$ | ||
| def s2 = $/def/$ | ||
| assert s1.size() == 4 && s2.size() == 3 |
There was a problem hiding this comment.
I’d assert expected values instead of size alone.
Contributor
There was a problem hiding this comment.
Does
def s1 = $/Failing string\\/$
With double backslash at the end work (as per the Jira example)?
Contributor
Author
There was a problem hiding this comment.
The double backslash case works - I'll adjust the test accordingly and also with expected values.
Contributor
There was a problem hiding this comment.
Awesome as always Paul 😎👍
paulk-asert
force-pushed
the
groovy10024
branch
from
bd8392b to
2b341fd
Compare
Contributor
Author
|
Proposed PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e parser