GROOVY-7001: DGM: return exact type for methods accepting collector#1656
Merged
paulk-asert merged 1 commit intomasterfrom Nov 26, 2021
Merged
GROOVY-7001: DGM: return exact type for methods accepting collector#1656paulk-asert merged 1 commit intomasterfrom
paulk-asert merged 1 commit intomasterfrom
Conversation
paulk-asert
reviewed
Nov 26, 2021
Contributor
paulk-asert
left a comment
There was a problem hiding this comment.
These changes seem okay to me and japicmp seems happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GROOVY-7001
I stopped short of
collectEntriesmethods. They don't have quite the same problem -- map return is probably okay, whereas the distinction between set, list and collection is often important.I also changed the return type of some variants to List and added the Collection bridges.
There is some inconsistency between some the variations. In cases where the input and output types are different, collect (except map variant) is listing the input type first where collectMany and others list input type(s) second. I did not make any changes (except to use
Einstead ofS).