Skip to content

Conversation

@paulk-asert
Copy link
Contributor

…orrectly resolved

@paulk-asert
Copy link
Contributor Author

paulk-asert commented Mar 31, 2022

The PR works for the simple case of the initial value being a reference to a previously defined parameter, as in the provided example, but should really be a visitor so that it could handle expressions involving such parameters. I'll do that next.
Now also handling subexpressions.

@paulk-asert paulk-asert marked this pull request as draft March 31, 2022 14:15
@paulk-asert paulk-asert force-pushed the groovy10561 branch 2 times, most recently from 69586dd to bbe78ef Compare April 1, 2022 01:42
@paulk-asert paulk-asert marked this pull request as ready for review April 1, 2022 04:35
@eric-milles
Copy link
Member

Is this the same way Verifier handles it for normal methods?

@paulk-asert
Copy link
Contributor Author

This has been simplified to be more like Verifier. I think there is still scope for catering for additional subexpressions but we can cover that in future changes.

@paulk-asert paulk-asert merged commit e2fd9e6 into apache:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants