Skip to content

Fix minor typos in subprojects javadoc and comments#1801

Merged
paulk-asert merged 1 commit intoapache:masterfrom
marcwrobel:fix-typos-subprojects
Oct 21, 2022
Merged

Fix minor typos in subprojects javadoc and comments#1801
paulk-asert merged 1 commit intoapache:masterfrom
marcwrobel:fix-typos-subprojects

Conversation

@marcwrobel
Copy link
Contributor

@marcwrobel marcwrobel commented Oct 18, 2022

Note that the following words / expressions were preferred :

The documentation of DataSet#rows() were altered because it did not look right. Let me know if this change should be reverted.

Note that the following words / expressions were preferred :

- meta data -> metadata (incorrect, see https://www.merriam-webster.com/dictionary/metadata)
- sub-type -> subtype (more common, see https://www.merriam-webster.com/dictionary/subtype)
- sub-directory -> subdirectory (more common, see https://www.merriam-webster.com/dictionary/subdirectory)
- whether or not -> whether (when possible because it is easier to read)

Empty catch blocks has been documented to prevent the following sonatype-lift warning: https://google.github.io/styleguide/javaguide.html#s6.2-caught-exceptions.
@paulk-asert paulk-asert merged commit 618dcb7 into apache:master Oct 21, 2022
@paulk-asert
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants