Skip to content

Conversation

@octylFractal
Copy link
Contributor

The documentation for this method states that when mutate is false, a new collection is always returned. The previous code only did so when self.size() was greater than 1, and otherwise returned null.

The documentation for this method states that when `mutate` is false, a new collection is _always_ returned. The previous code only did so when self.size() was greater than 1, and otherwise returned null.
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.5311%. Comparing base (4725c43) to head (e17ebc6).
Report is 485 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2056        +/-   ##
==================================================
+ Coverage     68.5281%   68.5311%   +0.0030%     
+ Complexity      29177      29176         -1     
==================================================
  Files            1422       1422                
  Lines          113495     113493         -2     
  Branches        19548      19547         -1     
==================================================
+ Hits            77776      77778         +2     
+ Misses          29178      29175         -3     
+ Partials         6541       6540         -1     
Files with missing lines Coverage Δ
.../codehaus/groovy/runtime/DefaultGroovyMethods.java 73.6213% <100.0000%> (+0.0157%) ⬆️

... and 2 files with indirect coverage changes

@paulk-asert paulk-asert merged commit a43d5d4 into apache:master Feb 14, 2024
@paulk-asert
Copy link
Contributor

Merged, thanks! There is a small tweak we can do to get the minor performance gain that I think the original code was after, but I can do that after the merge.

@octylFractal octylFractal deleted the bugfix/restore-unique-compatibility branch February 14, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants