Skip to content

GROOVY-11922: Jakarta EE 11 compatibility for groovy-servlet#2461

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy11922
Apr 11, 2026
Merged

GROOVY-11922: Jakarta EE 11 compatibility for groovy-servlet#2461
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy11922

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@utafrali utafrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bumps from Servlet 6.0 to 6.1 and JSP API 3.1.1 to 4.0.0 are correct, and the verification metadata SHA-512 hashes are the right length (128 hex chars). The main concern is the documentation's unqualified backward compatibility claim with Jakarta EE 10 containers, which could mislead users if any Servlet 6.1-specific API is called at runtime.

Comment thread subprojects/groovy-servlet/src/spec/doc/servlet-userguide.adoc Outdated
Comment thread gradle/verification-metadata.xml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.4936%. Comparing base (0e89696) to head (6e1af70).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2461        +/-   ##
==================================================
+ Coverage     66.4876%   66.4936%   +0.0059%     
- Complexity      30269      30273         +4     
==================================================
  Files            1411       1411                
  Lines          118031     118031                
  Branches        20989      20989                
==================================================
+ Hits            78476      78483         +7     
+ Misses          33077      33073         -4     
+ Partials         6478       6475         -3     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulk-asert paulk-asert merged commit 071f28f into apache:master Apr 11, 2026
22 of 23 checks passed
@paulk-asert paulk-asert deleted the groovy11922 branch April 11, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants