GROOVY-12031: Provide a DGM#takeIf method#2553
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
==================================================
+ Coverage 68.1844% 68.1855% +0.0011%
- Complexity 33086 33090 +4
==================================================
Files 1508 1508
Lines 126130 126131 +1
Branches 22878 22878
==================================================
+ Hits 86001 86003 +2
Misses 32490 32490
+ Partials 7639 7638 -1
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Groovy GDK extension method takeIf (GROOVY-12031) to DefaultGroovyMethods, allowing values to be conditionally passed through fluent chains (returning the receiver or null), and updates inspector expectations accordingly.
Changes:
- Introduces
DefaultGroovyMethods#takeIf(T, Predicate)with GroovyDoc examples (inlinegroovyTestCasecoverage). - Updates
InspectorTest’s expected meta method name list to includetakeIf.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java | Adds the new takeIf GDK method and its GroovyDoc examples/tests. |
| src/test/groovy/groovy/inspect/InspectorTest.java | Updates meta-method name expectations to account for the newly added DGM method. |
Comment on lines
+15094
to
+15095
| public static <T> T takeIf(T self, Predicate<T> condition) { | ||
| return condition.test(self) ? self : null; |
✅ All tests passed ✅Test Summary
🏷️ Commit: af0f1b9 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.