reject backslash in grape ivy coordinate validation#2581
Merged
paulk-asert merged 1 commit intoJun 1, 2026
Merged
Conversation
✅ All tests passed ✅🏷️ Commit: 0670be1 Learn more about TestLens at testlens.app. |
Contributor
|
Merged, thanks! I think this is already protected at the Ivy level but doesn't harm to also include it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coordinate check in createGrabRecord rejects / : " < > | in version and revision values, but the character class leaves out the backslash it claims to forbid, so a value such as ....\x slips through on Windows and is later interpolated into grape cache file paths. GrapeMaven already escapes the backslash in the same class; this brings GrapeIvy in line.