use Files.createTempFile for owner-only groovysh/groovyc temp files#2652
Merged
paulk-asert merged 1 commit intoJul 1, 2026
Merged
Conversation
✅ All tests passed ✅🏷️ Commit: 859178d Learn more about TestLens at testlens.app. |
Contributor
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/lessand/nanowrite the interactive session buffer to a temp file created withjava.io.File.createTempFile, which under a typical umask (022) is created world-readable (rw-r--r--). The buffer often holds connection strings, tokens, or credentials the user has typed.Groovyc.addSourceFileswrites the forked compilers source-file list to a temp file the same way when the command line exceeds the Windows length limit.THREAT_MODEL.md), but these temp files were still using thejava.ioAPI.Switched the three sites to
java.nio.file.Files.createTempFile(...).toFile(), which yields owner-only (rw-------) permissions on POSIX. Behavior for the owning user is unchanged; the forked compiler and the jline pager run as the same user, so the tighter mode does not affect them.Verified locally that
java.io.File.createTempFileproducesrw-r--r--under umask 022 whileFiles.createTempFileproducesrw-------; the two modules compile cleanly.