remove unnecessary Gradle wrapper configuration

[oreissig]

wrapper is an implicit Gradle task, you don't need to create one manually, just call e.g.
./gradlew wrapper --gradle-version=2.12

[blackdrag]

not sure about this commit. You are right in that there is a builtin wrapper task and that our wrapper task should not be needed. But the soruce distribution comes without the gradlew files. So how does a user know what gradle version to use to ensure there are no problems with the built related to the built tool version? Right now we can tell people to use any gradle to execute the wrapper task and then work with the wrappers from there on

[oreissig]

Thanks for the feedback. Actually I forgot about the source distribution. Why does it miss the gradle wrapper at all?

Now that you mentioned it, one of my previous pull requests removed the declaration of wrapper generation as default task in Gradle, thereby breaking the documentation describing the bootstrap of the source distribution. We should either

1. include the Gradle wrapper in the source distribution, or
2. change the README.adoc to call gradle wrapper instead of gradle (we may configure the Gradle version on the implicit wrapper task instead of defining our own).

[paulk-asert]

-1 on this change. Apache source distro's can't have the wrapper jar (a binary). They make some minor exceptions but to date the gradle wrapper isn't one of the allowable exceptions. The downloadWrapper task was meant to be a default task but that must have been overlooked in earlier commits. I just fixed that, so now the doco should be correct. This still leaves the implicit wrapper task with an explicit version free should someone wish to not abide by our recommendations.

[oreissig]

Thanks for the explanation.

I still think it is a good idea to not use a default task, so that Gradle prints a helpful splash screen when invoked without arguments instead of altering your working copy. I propose to document the use of Gradle's implicit wrapper task. Its version can still be overridden on the command line as described in the Gradle manual. I may also link to the Gradle documentation describing this use case in the README.adoc if desired.

[oreissig]

rebased from master

[paulk-asert]

This looks better. Nice work. I'll just double check that everything works as expected before merging.

[paulk-asert]

Looks like you've deleted the repo. Okay if I apply manually?

[oreissig]

Please feel free 👍

[paulk-asert]

merged, thanks!