Extra test cases for Collection .intersect() and .disjoint()#402
Closed
yackx wants to merge 1 commit intoapache:masterfrom
Closed
Extra test cases for Collection .intersect() and .disjoint()#402yackx wants to merge 1 commit intoapache:masterfrom
yackx wants to merge 1 commit intoapache:masterfrom
Conversation
asfgit
pushed a commit
that referenced
this pull request
Aug 28, 2016
Contributor
|
Thanks! More tests are always a good thing. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection.intersect()was partly broken (or at least utterly inconsistent) between versions2.4.2and2.4.6. Simple test case:would fail in the aforementioned versions as
[]would be returned. This is fixed in2.4.7but to avoid future regressions, it is nice to have test covering this case, as suggested by @glaforge and @sbglasius on Twitter.A basic search didn't reveal any similar test cases (some
Foointersection comparison can be found but it can be seen as a different test case).