GROOVY-4018: Make the Groovy truth value of NaN be false #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1, looks okay to me but I'm not super familiar with how performance might be affected at this level |
Contributor
Author
|
Thanks for looking it over, I appreciate it. I'll let it sit for a while and see if I can get some time to do a quick benchmark. Not sure how often |
jwagenleitner
force-pushed
the
GROOVY-4018-groovytruth-NaN
branch
from
f5f090a to
ceb9e18
Compare
jwagenleitner
force-pushed
the
GROOVY-4018-groovytruth-NaN
branch
3 times, most recently
from
3a22891 to
d7f5867
Compare
jwagenleitner
force-pushed
the
GROOVY-4018-groovytruth-NaN
branch
from
d7f5867 to
bd416bb
Compare
Contributor
Author
|
Updated the PR to consolidate the primitive-to-boolean conversion for both prim opts and static compilation and changed since tags to |
Contributor
|
LGTM. How about we change the since version to 2.6.0 and merge into master and GROOVY_2_6_X? |
Contributor
Author
|
Thanks Paul, I updated the since tags and merged into the branches suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just thought I'd take a stab at implementing this, maybe there are performance concerns with this. It may be more efficient to use
FLOAD/DLOADbefore theisNaNcall instead of theDUP2up front, but in the context of those methods I wasn't sure how to access the index of the variable on the stack.