GROOVY-7946 - allow writable values for StreamingJsonBuilder#429
Closed
graemerocher wants to merge 5 commits intoapache:GROOVY_2_4_Xfrom
Closed
GROOVY-7946 - allow writable values for StreamingJsonBuilder#429graemerocher wants to merge 5 commits intoapache:GROOVY_2_4_Xfrom
graemerocher wants to merge 5 commits intoapache:GROOVY_2_4_Xfrom
Conversation
Member
|
+1 |
| * Writes the given Writable as the value of the given attribute name | ||
| * | ||
| * @param name The attribute name The attribute name | ||
| * @param json The value The writable |
Contributor
There was a problem hiding this comment.
descriptions for the params seems to be repeated twice.
Contributor
Author
There was a problem hiding this comment.
Nice catch. Fixed.
Contributor
|
+1 |
Contributor
Author
|
Any chance this can be merged? Thanks... |
Contributor
Author
|
Actually hold off merging, found an a potential issue and will revise the test case and update the pull request |
…rocher/incubator-groovy into json-builder-writable-improvement
Contributor
Author
|
Revised pull request, since it created issues handling |
Contributor
Author
|
The failures on Travis seem to be unrelated network issues? |
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2016
Contributor
|
PR merged, thanks! Travis doesn't seem to always like building against the 2_4_X branch, seems to fail spuriously. Hope you don't mind but I squashed the commits. |
blindpirate
pushed a commit
to blindpirate/groovy
that referenced
this pull request
Nov 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/GROOVY-7946