Console, GroovyMain and Groovysh (via its Main) use context class loader

[eric-milles]

• All: pass system properties to new CompilerConfiguration instances
• Console: use default parameters to reduce constructor variants

As discussed with @paulk-asert; support for starting Colsole, et al. using GroovyStarter. This would allow separate classpath similar to how compiler has transform classpath (for tooling) and standard classpath (for user code).

See also groovy/groovy-eclipse#890

NOTE: I don't have any unit tests created yet. Essentially I would load Console using GroovyStarter, as I have tested separately.

[daniellansun]

Merged. Thanks!

[eric-milles]

Could I get this merged into 2_5_X and 2_4_X? Or do I need to create separate requests for each?

[daniellansun]

If we decide to merge the PR into 2_5_X and 2_4_X, no more PR required. As we all know, 2_5_X and 2_4_X are maintainance branches, so only bug fixes are merged into the two branches usually.
BTW, it's better to create a JIRA ticket to record the non-trivial changes.
@paulk-asert what do you think about.the.suggestion to merge into 2_5_X and 2_4_X?

[eric-milles]

I understand about branches and tickets. I submitted this request to see if my idea would be acceptable or needed a rethink. I didn't get much direction from email conversation, but had a workable solution in hand.

As I linked, I've been working a ticket out of another project. It will be very difficult for me to proceed unless I have uniform support in 2.4, 2.5 and 3.0.

[paulk-asert]

I haven't had time to review original PR as yet.