GUACAMOLE-392: add basic travis-ci integration#188
Closed
chipitsine wants to merge 1 commit intoapache:masterfrom
chipitsine:travis-ci
Closed
GUACAMOLE-392: add basic travis-ci integration#188chipitsine wants to merge 1 commit intoapache:masterfrom chipitsine:travis-ci
chipitsine wants to merge 1 commit intoapache:masterfrom
chipitsine:travis-ci
Conversation
mike-jumper
reviewed
Sep 24, 2017
| language: java | ||
|
|
||
| script: | ||
| - mvn install -DskipTests=true -Drat.skip=true -Dmaven.javadoc.skip=true -B -V |
Contributor
There was a problem hiding this comment.
As with apache/guacamole-server#110, I'm not confident Travis CI is a good choice. Depending on the result of discussion, if we do choose to go with Travis, skipping parts of the build shouldn't be done, especially tests and the RAT check. Catching test failures is one of the key points of using CI.
Author
There was a problem hiding this comment.
as for skipping RAT check, I left that to those who understands how to deal with that :) I do not insist in skipping actually
Contributor
|
@chipitsine - as with apache/guacamole-server#110, please close this PR when you can. We are now using Jenkins for CI. |
Author
|
closing in favour of jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.