GUACAMOLE-635: Require Java 1.8 for all Java components except guacamole-common.#324
Merged
asfgit merged 2 commits intoapache:staging/1.0.0from Sep 29, 2018
Merged
Conversation
…ObjectType... objects). From https://docs.oracle.com/javase/tutorial/java/generics/nonReifiableVarargsType.html#vulnerabilities: "Heap pollution occurs when a variable of a parameterized type refers to an object that is not of that parameterized type." In this case, the parameterized type (ObjectType) and the array of that type within this constructor are always used as their formal types.
necouchman
approved these changes
Sep 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #319 and on the dev@ mailing list, this change bumps the Java requirement for all Java components to 1.8, with the exception of guacamole-common which remains at 1.6.
There is one change here that isn't simply bumping "1.6" to "1.8": the addition of the
@SafeVarargsannotation to theSimpleDirectory<ObjectType>constructor that accepts a varargs array ofObjectType. This is due to a new warning regarding "heap pollution" introduced in newer Java compilers.From Oracle's documentation on heap pollution: