GUACAMOLE-742: Use "data-disabled" instead of "disabled" for directive attributes.#405
Merged
necouchman merged 1 commit intoapache:masterfrom May 17, 2019
Merged
Conversation
…e attributes. Internet Explorer 11 interprets the "disabled" attribute on all HTML elements, even unknown elements like AngularJS directives, disabling any input fields that end up on the DOM tree within those elements. This breaks the login form. The alternative "data-disabled" attribute form supported by AngularJS allows things to work without interference.
necouchman
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internet Explorer 11 interprets the
disabledattribute on all HTML elements, even unknown elements like AngularJS directives, disabling any input fields that end up on the DOM tree within those elements. This breaks the login form.The alternative
data-disabledattribute form supported by AngularJS allows things to work without interference.