Skip to content

GUACAMOLE-781: CS Translation updated #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vict0rC wants to merge 1 commit into from
Closed

GUACAMOLE-781: CS Translation updated #558

Vict0rC wants to merge 1 commit into from

Conversation

@Vict0rC
Copy link
Contributor

@Vict0rC Vict0rC commented Aug 12, 2020 •
edited
Loading

GUACAMOLE-781: Corrections and additions to Czech translation

@odolezal
Copy link

odolezal commented Oct 2, 2020

Please review this pull request.

Thanks.

necouchman
necouchman requested changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look fine to me - my only request is that the commit message be updated to be a little more useful in its content. See the following page that Mike dug up that has suggestions and examples - good and bad - of commit messages:

https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/

@Vict0rC
Copy link
Contributor Author

Vict0rC commented Dec 4, 2020

I have no idea how to describe it better :-( Sorry :-(
Could you please advice better description?
Thank you...

@necouchman
Copy link
Contributor

necouchman commented Dec 26, 2020

I have no idea how to describe it better

Something like:

GUACAMOLE-781: Corrections and additions to Czech translation

Doesn't have to be fancy, just something that will make it easier when looking through a commit log to see what the point of the changes was.

@necouchman
Copy link
Contributor

necouchman commented May 13, 2021

@Vict0rC Would like to get these translation updates added into the code - can you update the commit message as requested?

@Vict0rC Vict0rC requested a review from necouchman May 19, 2021 09:31
@Vict0rC
GUACAMOLE-781: Translation updated
f82476d 
GUACAMOLE-781: Corrections and additions to Czech translation
@Vict0rC Vict0rC closed this May 19, 2021
This was referenced Jun 24, 2023
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@necouchman necouchman Awaiting requested review from necouchman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vict0rC @odolezal @necouchman