GUACAMOLE-1207: Add Portuguese translation #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
requested changes
Nov 16, 2020
Contributor
necouchman
left a comment
necouchman
left a comment
There was a problem hiding this comment.
Overall looks pretty good to me, just one or two things to note:
- If you're not translating a string, leave it out of the translation file, and it will fall back to the English translation. If the translation is identical in Portuguese as in English, it should be included in the translation file.
- In the JDBC module, you need to modify the
guac-manifest.jsonfiles for each of the modules and add the pt.json translation:
Contributor
|
@rbm0407: Looking pretty good. However, now you have some extra commits - please squash them all down into a single commit, and make sure the commit message is descriptive. After that I think it'll be ready to go! |
Add translation files for the webapp and the following extensions: - guacamole-auth-cas - guacamole-auth-duo - guacamole-auth-jdbc - guacamole-auth-openid - guacamole-auth-quickconnect - guacamole-auth-saml - guacamole-auth-totp
Contributor
Author
|
Sorry, this is my first pull request with review hahaha Squashed to a single commit |
necouchman
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translation files for the webapp and the following extensions: