GUACAMOLE-462: Request correct sort order from REST API when searching history.#712
Merged
jmuehlner merged 1 commit intoapache:staging/1.5.0from Mar 31, 2022
Merged
Conversation
jmuehlner
reviewed
Mar 31, 2022
guacamole/src/main/frontend/src/app/settings/directives/guacSettingsConnectionHistory.js
Show resolved
Hide resolved
jmuehlner
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The history screen does not display the correct set of history entries as of recent changes from GUACAMOLE-462. This is because the sort properties of the table in the UI no longer match the sort properties used by the REST API, resulting in only very old records being displayed:
Translating the new properties to the proper REST API properties solves the issue:
The incorrect behavior is only reproducible on a system with more than 1000 history records. On systems with fewer records, the same records will be present in the returned set regardless of how they are sorted.