GUACAMOLE-1728: Allow Null User Object attributes to be saved.

[aleitner]

Attributes with a value of null get filtered out when saving objects. An empty timezone attribute is null, but we want to save null value attributes.

[mike-jumper]

What does `setAttributes()` receive when the timezone field has been cleared?

…

On Wed, Dec 28, 2022, 1:02 PM Alexander Leitner ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In guacamole/src/main/java/org/apache/guacamole/rest/user/UserResource.java <#783 (comment)> : > @@ -150,6 +150,10 @@ public void updateObject(APIUser modifiedObject) throws GuacamoleException { throw e; } + /* Force updateObject to save the timezone when it is empty */ + if (modifiedObject.getAttributes().get("timezone") == null) + modifiedObject.getAttributes().put("timezone", ""); + The alternative that I can think of would be to have the empty timezone be represented as an empty string rather than null on the javascript side — Reply to this email directly, view it on GitHub <#783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDLCSMFKYP3RUYWQZTOG6DWPSTHDANCNFSM6AAAAAATLRDYLM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mike-jumper]

Please update your commit message to reflect the high-level nature of the change.