GUACAMOLE-313: Add "guaclog" utility for producing human-readable interpretations of keys pressed in session recordings#137
Merged
asfgit merged 10 commits intoapache:masterfrom Jan 30, 2018
Conversation
necouchman
approved these changes
Jan 29, 2018
Contributor
necouchman
left a comment
necouchman
left a comment
There was a problem hiding this comment.
Looks fine to me, but, again, I think maybe @ceharris @flangelo or @jmuehlner should double-check my review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new utility, "guaclog", which is analogous to guacenc in that it interprets the contents of session recordings or protocol dumps. Unlike guacenc, the guaclog utility tracks the current state of keys pressed, producing a human-readable log of what has been typed within a session.
Note that Guacamole does not currently log keys within session recordings, and the under-development support for this must be manually enabled if a recording should contain key events. For this to be useful to someone wishing to audit a Guacamole session, logging of key events would need to have been manually enabled ahead of time, or the full raw contents of that session (captured via tcpdump, for example) would need to be available.