GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
reviewed
Jan 23, 2019
jmuehlner
reviewed
Jan 23, 2019
jmuehlner
reviewed
Jan 23, 2019
jmuehlner
reviewed
Jan 23, 2019
jmuehlner
reviewed
Jan 23, 2019
…n libguac source.
…gs using a given delimiter.
…rl*(). Fix return values.
…strlcat() to be available in libc's string.h.
…sr/bin/env perl` should be used for portability.
…Make. As otherwise POSIX-compliant platforms may not provide this variable, we shouldn't use it here.
mike-jumper
force-pushed
the
string-functions
branch
from
3b2e269 to
b7761e9
Compare
…ent the destination buffer is not terminated as required.
…ormalization logic to ensure that empty component is always present.
Contributor
|
Changed merge base to |
…de test output. Remove duplicated exclusions.
…or to match documentation.
Contributor
|
Ok, I think everything looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds platform-independent libguac implementations of the
strlcpy()andstrlcat()functions,guac_strlcpy()andguac_strlcat(), provided via a newguacamole/string.hheader. These functions will use the versions provided by the platform's libc, if available.Unlike
strncpy()andstrncat(), thestrlcpy()andstrlcat()variants guarantee that the destination buffer is null-terminated, even if the result had to be truncated: https://www.freebsd.org/cgi/man.cgi?query=strlcpy&sektion=3&manpath=FreeBSD+6.2-RELEASEThis change also adds a similar convenience function,
guac_strljoin(), which provides an implementation of the familiar "join" operation for strings.Unit tests have been added for each of the new functions.