GUACAMOLE-847: Fix severe memory leak when using audio with RDP#229
Merged
mike-jumper merged 1 commit intoapache:masterfrom Jul 20, 2019
fhriley:master
Merged
GUACAMOLE-847: Fix severe memory leak when using audio with RDP#229mike-jumper merged 1 commit intoapache:masterfrom fhriley:master
mike-jumper merged 1 commit intoapache:masterfrom
fhriley:master
Conversation
mike-jumper
requested changes
Jul 20, 2019
Contributor
There was a problem hiding this comment.
In spirit, these changes look fine, and I can confirm by checking the FreeRDP source that none of the 1.x releases will free the memory for that wStream on their own. However:
- Please correct the style of the changes to match that of the existing code (we don't cuddle the
else). - Please correct the indentation. I'm not sure what happened, but the comments for the various
casestatements are now misaligned.
Contributor
Author
|
Done, I believe the style matches other code now. There are 2 confirmations that this is the correct fix:
|
mike-jumper
approved these changes
Jul 20, 2019
Contributor
mike-jumper
left a comment
mike-jumper
left a comment
There was a problem hiding this comment.
Looks great to me, and seems to be the only reasonable way to resolve given the circumstances. I can only hope FreeRDP doesn't add their own Stream_Free() within the caller in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak that leaks 4+ GBs over an 8 hour period when continuous audio is being played through RDP.