-
Notifications
You must be signed in to change notification settings - Fork 733
GUACAMOLE-968: Add Norwegian keymap #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
necouchman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks okay to me - as with your PR on the client side:
- Addition of the Makefile entry should be in (roughly) alphabetical order.
- Pull Request and Commit Messages need the GUACAMOLE-968 tag on them.
|
I fixed the entry order, renamed the pull request, and the commit message for the new version of the files. Is there a way of changing the previous commit message after the fact, or will that do bad things to the pull request/version management? |
Yes, you can do an interactive rebase, choose the option to modify the commit message, and then fix the messages. After you're done do a force push and it should be good. |
|
Also note that the correct format for both PR (which you've done properly) and commit messages is "GUACAMOLE-968: ". |
3ebfa64 to
d8fdd77
Compare
|
I'm (slowly) getting the hang of this; thanks again! I think the requested changes are in place now. |
mike-jumper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Yep. Caps Lock will not behave correctly without the keymap dictating Caps Lock's behavior. |
|
@oxcrag This still needs to be updated to take Caps Lock changes into account. |

No description provided.