GUACAMOLE-221: Handle FREERDP_ERROR_* constants only when defined. #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only FreeRDP 2.0.0-rc3 and later support all the constants used within src/protocols/rdp/error.c.
necouchman
approved these changes
Nov 3, 2020
Contributor
necouchman
left a comment
necouchman
left a comment
There was a problem hiding this comment.
That's a lot of ifdefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #308 broke the build against FreeRDP 2.0.0-rc2 and earlier. This is because earlier versions of FreeRDP do not support all the constants used within
error.c.This change wraps affected constants in
#ifdef/#endif, handling that specific error constant only if it's actually defined.