GUACAMOLE-1064: add Norwegian keyboard#342
Merged
mike-jumper merged 1 commit intoapache:masterfrom Jun 3, 2021
Merged
Conversation
Contributor
|
@oharboe: Looks fine without having an actual keyboard to test it with. Unfortunately I don't have a way to test, either 😄 |
Contributor
Author
|
@necouchman Is there a way to test this beyond manual integration testing, i.e. set up a couple of machines w/Guacamole? |
Contributor
|
@oharboe, no, there is no automated test mechanism for keyboard layout behavior. The only way to test that a new keyboard layout behaves correctly is to deploy and directly test against an RDP connection using that layout. |
oharboe
force-pushed
the
rdp-norwegian-keyboard
branch
from
e74a57a to
840bf85
Compare
Contributor
Author
|
@mike-jumper Tested. Seems to work :-)
|
mike-jumper
requested changes
Jun 3, 2021
Contributor
mike-jumper
left a comment
mike-jumper
left a comment
There was a problem hiding this comment.
Except for the ordering of the keymaps (see comment), this LGTM.
Tested on top of Guacamole 1.3.0 The following works beyond a simple smoke-test: - æøå - \ - | - dead acute á - dead grave à - dead umlaut ö - dead cirumflex ê - dead tilde ~
oharboe
force-pushed
the
rdp-norwegian-keyboard
branch
from
840bf85 to
910c87b
Compare
mike-jumper
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jmoehlma Best guess... How do I test this?