Adapt to const parameters of ffmpeg 5.0 #379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@dfandrich Thank you for your contribution. In order for us to merge this and include it with the code, you will need to submit a Jira issue for it and tag both the pull request and commit messages with the Jira issue. In addition to the links below, have a look at the other pull requests to see examples. https://guacamole.apache.org/open-source/ |
Contributor
|
Superseded by #399, which amends these changes to include the JIRA issue in the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a few parameters are now const which guacamole treats as
non-const. Mark some variables and parameters as const to match. This
should be pretty safe and compatible. I've verified only that this now
compiles without error.