Skip to content

HDDS-1756. DeleteContainerCommandHandler fails with NPE.#1095

Merged
mukul1987 merged 1 commit intoapache:trunkfrom
nandakumar131:HDDS-1756
Jul 16, 2019
Merged

HDDS-1756. DeleteContainerCommandHandler fails with NPE.#1095
mukul1987 merged 1 commit intoapache:trunkfrom
nandakumar131:HDDS-1756

Conversation

@nandakumar131
Copy link
Contributor

This change will make delete container an idempotent operation in datanode.

Copy link
Contributor

@mukul1987 mukul1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, the changes look good to me. pending jenkins.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 489 trunk passed
+1 compile 240 trunk passed
+1 checkstyle 64 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 818 branch has no errors when building and testing our client artifacts.
+1 javadoc 153 trunk passed
0 spotbugs 310 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 505 trunk passed
_ Patch Compile Tests _
+1 mvninstall 426 the patch passed
+1 compile 255 the patch passed
+1 javac 255 the patch passed
+1 checkstyle 72 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 640 patch has no errors when building and testing our client artifacts.
+1 javadoc 147 the patch passed
-1 findbugs 166 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 54 hadoop-hdds in the patch failed.
-1 unit 34 hadoop-ozone in the patch failed.
0 asflicense 39 ASF License check generated no output?
4494
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1095/1/artifact/out/Dockerfile
GITHUB PR #1095
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 508bbfce471f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5446308
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1095/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1095/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1095/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1095/1/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service U: hadoop-hdds/container-service
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1095/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@mukul1987 mukul1987 merged commit 1502e6a into apache:trunk Jul 16, 2019
@nandakumar131 nandakumar131 deleted the HDDS-1756 branch July 16, 2019 14:13
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
* Offset.default for intermediate streams should default to upcoming for non-batch jobs
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants