Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Sep 23, 2019

…buf classes

@Apache9 Apache9 self-assigned this Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1733 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 32 Maven dependency ordering for branch
+1 mvninstall 1189 trunk passed
+1 compile 114 trunk passed
+1 mvnsite 64 trunk passed
+1 shadedclient 2133 branch has no errors when building and testing our client artifacts.
+1 javadoc 55 trunk passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 54 the patch passed
+1 compile 109 the patch passed
+1 cc 109 the patch passed
+1 javac 109 the patch passed
+1 mvnsite 50 the patch passed
-1 whitespace 0 The patch 6 line(s) with tabs.
+1 xml 4 The patch has no ill-formed XML file.
+1 shadedclient 814 patch has no errors when building and testing our client artifacts.
+1 javadoc 45 the patch passed
_ Other Tests _
+1 unit 59 hadoop-mapreduce-client-common in the patch passed.
+1 unit 31 hadoop-mapreduce-client-shuffle in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
5290
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/1/artifact/out/Dockerfile
GITHUB PR #1500
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc
uname Linux 8b485a712dc3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 07c81e9
Default Java 1.8.0_222
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/1/artifact/out/whitespace-tabs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/1/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 30 Maven dependency ordering for branch
+1 mvninstall 1116 trunk passed
+1 compile 112 trunk passed
+1 mvnsite 60 trunk passed
+1 shadedclient 2070 branch has no errors when building and testing our client artifacts.
+1 javadoc 56 trunk passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 54 the patch passed
+1 compile 105 the patch passed
+1 cc 105 the patch passed
+1 javac 105 the patch passed
+1 mvnsite 48 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 3 The patch has no ill-formed XML file.
+1 shadedclient 795 patch has no errors when building and testing our client artifacts.
+1 javadoc 45 the patch passed
_ Other Tests _
+1 unit 61 hadoop-mapreduce-client-common in the patch passed.
+1 unit 28 hadoop-mapreduce-client-shuffle in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
3508
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/2/artifact/out/Dockerfile
GITHUB PR #1500
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc
uname Linux 6cc32e8e7673 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / aa664d7
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/2/testReport/
Max. process+thread count 447 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1500/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@vinayakumarb vinayakumarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending whitespace and format corrections in pom.xmls

@Apache9 Apache9 merged commit e8e7d7b into apache:trunk Sep 24, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
…buf classes (apache#1500)

Signed-off-by: Vinayakumar B <vinayakumarb@apache.org>
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
…buf classes (apache#1500)

Signed-off-by: Vinayakumar B <vinayakumarb@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants