Skip to content

Conversation

@sjung-stripe
Copy link
Contributor

This contribution is on behalf of Stripe, and I believe we already have a corporate CLA with ASF.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 18m 58s trunk passed
+1 💚 compile 19m 24s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 16m 44s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 0m 51s trunk passed
+1 💚 mvnsite 1m 28s trunk passed
+1 💚 shadedclient 17m 9s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 38s hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 0m 58s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 2m 15s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 13s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 56s the patch passed
+1 💚 compile 20m 5s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
-1 ❌ cc 20m 5s root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 40 new + 122 unchanged - 40 fixed = 162 total (was 162)
+1 💚 golang 20m 5s the patch passed
+1 💚 javac 20m 5s the patch passed
+1 💚 compile 18m 24s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌ cc 18m 24s root-jdkPrivateBuild-1.8.0_252-8u252-b09-118.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-118.04-b09 generated 17 new + 145 unchanged - 17 fixed = 162 total (was 162)
+1 💚 golang 18m 24s the patch passed
+1 💚 javac 18m 24s the patch passed
-0 ⚠️ checkstyle 0m 51s hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 mvnsite 1m 24s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 57s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 45s hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 1m 2s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 2m 28s the patch passed
_ Other Tests _
+1 💚 unit 9m 42s hadoop-common in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
151m 42s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/artifact/out/Dockerfile
GITHUB PR #2104
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc golang
uname Linux 3aede0da50ad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / bed0a3a
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
cc https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
cc https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/testReport/
Max. process+thread count 2033 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2104/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 19m 33s trunk passed
+1 💚 compile 20m 52s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 18m 37s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 0m 53s trunk passed
+1 💚 mvnsite 1m 35s trunk passed
+1 💚 shadedclient 19m 57s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 41s hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚 javadoc 1m 5s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 2m 37s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 35s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 3s the patch passed
+1 💚 compile 22m 48s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌ cc 22m 48s root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 28 new + 134 unchanged - 28 fixed = 162 total (was 162)
+1 💚 golang 22m 48s the patch passed
+1 💚 javac 22m 48s the patch passed
+1 💚 compile 20m 2s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌ cc 20m 2s root-jdkPrivateBuild-1.8.0_252-8u252-b09-118.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-118.04-b09 generated 36 new + 126 unchanged - 36 fixed = 162 total (was 162)
+1 💚 golang 20m 2s the patch passed
+1 💚 javac 20m 2s the patch passed
-0 ⚠️ checkstyle 0m 52s hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 mvnsite 1m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 38s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 42s hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚 javadoc 1m 2s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 2m 35s the patch passed
_ Other Tests _
+1 💚 unit 9m 39s hadoop-common in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
166m 6s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/artifact/out/Dockerfile
GITHUB PR #2104
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc golang
uname Linux 571eaec0ed21 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 05b3337
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/testReport/
Max. process+thread count 3249 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2104/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In fact, we should add the test from the jira as well... Let me merge this PR and I'll raise a follow up jira to attach the test.

@jojochuang jojochuang merged commit 45434c9 into apache:trunk Nov 10, 2020
asfgit pushed a commit that referenced this pull request Nov 10, 2020
…ntributed by Stephen Jung (Stripe).

(cherry picked from commit 45434c9)
(cherry picked from commit 0712505)
asfgit pushed a commit that referenced this pull request Nov 10, 2020
…ntributed by Stephen Jung (Stripe).

(cherry picked from commit 45434c9)
asfgit pushed a commit that referenced this pull request Nov 10, 2020
…ntributed by Stephen Jung (Stripe).

(cherry picked from commit 45434c9)
asfgit pushed a commit that referenced this pull request Nov 28, 2020
…ntributed by Stephen Jung (Stripe).

(cherry picked from commit 45434c9)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…. Contributed by Stephen Jung (Stripe).

(cherry picked from commit 45434c9)
(cherry picked from commit 0712505)
(cherry picked from commit 9f7553b)
Change-Id: I895c55a78c07fd45fbdff36b641590f6b724138a
(cherry picked from commit 5ba54ead24a4a727c5b497f55402addfcba5a190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants