-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-15976. Make mkdtemp cross platform #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
5df023b to
5977b9f
Compare
|
💔 -1 overall
This message was automatically generated. |
* mkdtemp is used for creating temporary directory, adhering to the given pattern. It's not available on Visual C++. Need to make this cross platform.
* Refactored TempDir class to adhere to the Rule of 5 C++ idiom.
* Fixed the @return section in documentation.
5977b9f to
cb6f04c
Compare
|
💔 -1 overall
This message was automatically generated. |
* Need to append a null char so that mkdtemp can find the end of the string. It leds to a segfaul otherwise.
This reverts commit 373af53.
cb6f04c to
767c52f
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
* Appending null to the temp file name so that _mktemp_s can find the end of string and doesn't run into segfault.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
directory, adhering to the given pattern.
It's not available on Visual C++. Need
to make this cross platform.