-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16125: fix the iterator for PartitionedGSet #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvachko
reviewed
Jul 14, 2021
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PartitionedGSet.java
Outdated
Show resolved
Hide resolved
...p-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPartitionedGSet.java
Outdated
Show resolved
Hide resolved
...p-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPartitionedGSet.java
Outdated
Show resolved
Hide resolved
...p-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPartitionedGSet.java
Outdated
Show resolved
Hide resolved
prasad-acit
reviewed
Jul 14, 2021
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PartitionedGSet.java
Outdated
Show resolved
Hide resolved
also fixed a typo in readTopdUnlock and removed the unused rootDir Inode in PartitionedGSet constructor.
shvachko
reviewed
Jul 15, 2021
Contributor
shvachko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note:
Let's not force rebase on every commit.
It really helps to keep the history of changes on a PR.
The final merge to the repo should squash all these commits on the PR and make it one.
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PartitionedGSet.java
Outdated
Show resolved
Hide resolved
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PartitionedGSet.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jul 16, 2021
asfgit
pushed a commit
that referenced
this pull request
Jul 23, 2021
asfgit
pushed a commit
that referenced
this pull request
Jul 31, 2021
asfgit
pushed a commit
that referenced
this pull request
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the issue that iterator will visit the first partition twice.
also fixed a typo in readTopdUnlock and removed the unused rootDir Inode in PartitionedGSet constructor.
added TestPartitionedGSet.java.
mvn test -Dtest=TestPartitionedGSetpassed.