-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-18011. ABFS: Configurable HTTP connection and read timeouts #3662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
::: AGGREGATED TEST RESULT :::: HNS-OAuth[INFO] Results: HNS-SharedKey[INFO] Results: NonHNS-SharedKey[INFO] Results: Failed tests are not related to the change and different JIRAs are tracking the fixes. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Hi @mukund-thakur @mehakmeet , Kindly request your help to review this PR. Thanks. |
mukund-thakur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
Why is Yetus reporting this error?
| @Test(expected = InvalidAbfsRestOperationException.class) | ||
| public void testHttpReadTimeout() throws Exception { | ||
| // Small read timeout is bound to make the request fail. | ||
| testHttpTimeouts(TEST_STABLE_DEFAULT_CONNECTION_TIMEOUT_MS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
@snvijaya @anujmodi2021 is this still needed? |
ABFS driver has a default connection timeout and read timeout value of 30 secs. For jobs that are time sensitive, preference would be quick failure and have shorter HTTP connection and read timeout.
This change enables 2 configs: fs.azure.http.connection.timeout and fs.azure.http.read.timeout
that allows custom values to be configured for default HTTP connection and read timeout.
All the integration tests were run over ABFS accounts (pasted in PR conversation tab). New checks are added to the tests for config update and socket timeout.