HADOOP-16058 S3A tests to include Terasort #576
Closed
steveloughran wants to merge 4 commits intoapache:trunkfrom
Closed
HADOOP-16058 S3A tests to include Terasort #576steveloughran wants to merge 4 commits intoapache:trunkfrom
steveloughran wants to merge 4 commits intoapache:trunkfrom
Conversation
+ MAPREDUCE-7090, MAPREDUCE-7091, MAPREDUCE-7092: set the examples and terasort up for cloudstore testing Change-Id: I6b0bf12a6355bb8598a2db280c994876d93eb0f2
-Pulls up the code to set up MR clusters for committer tests into a new intermediate base class, one which does not contain the code to actually set up those base clusters. instead the cluster setup/teradown is done in the @BeforeClass/@afterclass operations of the subclasses, so guaranteeing isolation and a lifecycle which matches those child classes. Having done this, it hasn't made the terasort conflict go away; I've concluded now that that's due to some code in Terasort which uses LocalFS to save a partition list. Rather than do dramatic things to Terasort (e.g. add the ability to declare new local paths), I've just serialized the Terasorrt tests -after shrinking down their test size I haven't reverted the design which pushes cluster setup/teardown into the child classes, even though I'm not sure it is needed, just because it does make clear the lifecycle of class-level data types. +address checkstyle warnings from the previous patch, where possible. Change-Id: I781a2090ecbe78ff18a57b87a06b3149024554ea
Change-Id: I92d9704152f46b5bce30d1b16f63364dfcb0b7ee
…nInfo in HADOOP-16093. That'll resurface in other patches of mine, I suspect. Change-Id: Icfddb3470a32eb71b86f84d176ea2fae52b5adf5
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Jagadish <jvenkatraman@linkedin.com> Reviewers: Jagadish <jagadish@apache.org> Closes apache#576 from vjagadish1989/flakytest-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HADOOP-16058 S3A tests to include Terasort