Skip to content

Conversation

@steveloughran
Copy link
Contributor

S3A MarshalledCredentials.toString() doesn't print full date/time of expiry

Change-Id: I4f1bdd2be0d5760c5501dce6edb6122499108b53

Change-Id: I4f1bdd2be0d5760c5501dce6edb6122499108b53
@steveloughran
Copy link
Contributor Author

testing: been using this locally. Works in a toString() of a DT.

AWS Credentials=session credentials, expiry 2019-03-15T16:11:29Z; 

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 989 trunk passed
+1 compile 34 trunk passed
+1 checkstyle 24 trunk passed
+1 mvnsite 38 trunk passed
+1 shadedclient 723 branch has no errors when building and testing our client artifacts.
+1 findbugs 44 trunk passed
+1 javadoc 25 trunk passed
_ Patch Compile Tests _
+1 mvninstall 29 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
+1 checkstyle 18 the patch passed
+1 mvnsite 33 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 744 patch has no errors when building and testing our client artifacts.
+1 findbugs 50 the patch passed
+1 javadoc 24 the patch passed
_ Other Tests _
+1 unit 279 hadoop-aws in the patch passed.
+1 asflicense 27 The patch does not generate ASF License warnings.
3213
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-617/1/artifact/out/Dockerfile
GITHUB PR #617
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f9cc79d6fef8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cb4d911
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-617/1/testReport/
Max. process+thread count 415 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-617/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

been using this downstream, works well

@steveloughran steveloughran added the fs/s3 changes related to hadoop-aws; submitter must declare test endpoint label Mar 28, 2019
@lmccay
Copy link
Contributor

lmccay commented Mar 28, 2019

LGTM
+1

@steveloughran steveloughran merged commit df578c0 into apache:trunk Mar 28, 2019
@steveloughran
Copy link
Contributor Author

thanks, merged (from VS.code IDE, BTW)

@steveloughran steveloughran deleted the s3/HADOOP-16195-MarshalledCredentialsToString branch March 28, 2019 17:02
@steveloughran
Copy link
Contributor Author

ok, forgot to name myself as author when committing this through the IDE. Need to do that in future

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
The way that we verify the join counts in PageViewToProfileJoinFunction across multiple table tests (i.e. TestLocalTable, TestRemoteTable, TestLocalTableWithSideInputs) creates some conflicts in the static counter map and triggers test failure in certain sequence of ordering of tests. Fixing it by requiring explicit name of the join functions in tests and register / verify by unique op names.

Author: Yi Pan (Data Infrastructure) <nickpan47@gmail.com>

Closes apache#617 from nickpan47/SAMZA-1826 and squashes the following commits:

a25c484d [Yi Pan (Data Infrastructure)] SAMZA-1826: removing assertion on internal state of MapFunction in integration tests
566f13c5 [Yi Pan (Data Infrastructure)] SAMZA-1826: Fix unit test failure in table tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs/s3 changes related to hadoop-aws; submitter must declare test endpoint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants