Skip to content

HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. #6311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions ...op-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,16 +1206,6 @@ public void run() {
}
}

if (slownodesFromAck.isEmpty()) {
if (!slowNodeMap.isEmpty()) {
slowNodeMap.clear();
}
} else {
markSlowNode(slownodesFromAck);
LOG.debug("SlowNodeMap content: {}.", slowNodeMap);
}


assert seqno != PipelineAck.UNKOWN_SEQNO :
"Ack for unknown seqno should be a failed ack: " + ack;
if (seqno == DFSPacket.HEART_BEAT_SEQNO) { // a heartbeat ack
Expand Down Expand Up @@ -1259,6 +1249,15 @@ public void run() {
dataQueue.notifyAll();

one.releaseBuffer(byteArrayManager);
if (slownodesFromAck.isEmpty()) {
if (!slowNodeMap.isEmpty()) {
slowNodeMap.clear();
}
} else {
markSlowNode(slownodesFromAck);
// TODO remove out of synchronized.
LOG.debug("SlowNodeMap content: {}.", slowNodeMap);
}
}
} catch (Throwable e) {
if (!responderClosed) {
Expand Down
2 changes: 1 addition & 1 deletion ...doop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestClientProtocolForPipelineRecovery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ public void markSlow(String mirrorAddr, int[] replies) {
int count = 0;
Random r = new Random();
byte[] b = new byte[oneWriteSize];
while (count < threshold) {
while (count < threshold + 1) {
r.nextBytes(b);
o.write(b);
count++;
Expand Down