Skip to content

HADOOP-19398: Upgrade Dockerfile base to jammy#7320

Closed
YanivKunda wants to merge 170 commits intoapache:trunkfrom
YanivKunda:HADOOP-19398-upgrade-Dockerfile-base-to-jammy
Closed

HADOOP-19398: Upgrade Dockerfile base to jammy#7320
YanivKunda wants to merge 170 commits intoapache:trunkfrom
YanivKunda:HADOOP-19398-upgrade-Dockerfile-base-to-jammy

Conversation

@YanivKunda
Copy link
Contributor

@YanivKunda YanivKunda commented Jan 23, 2025

Description of PR

Upgrade the base image of the Ubuntu Dockerfiles used for CI and local development.

How was this patch tested?

  1. Created and started the build env: ./start-build-env.sh
  2. Built native profile (within the container): mvn clean install -Pnative -DskipTests

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

hadoop-yetus commented Jan 23, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shellcheck 0m 0s Shellcheck was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 hadolint 0m 0s hadolint was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 5m 47s Maven dependency ordering for branch
-1 ❌ mvninstall 18m 55s /branch-mvninstall-root.txt root in trunk failed.
-1 ❌ compile 6m 44s /branch-compile-root.txt root in trunk failed.
-1 ❌ mvnsite 2m 21s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 shadedclient 53m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
-1 ❌ mvninstall 17m 50s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 1m 28s /patch-compile-root.txt root in the patch failed.
-1 ❌ cc 1m 28s /patch-compile-root.txt root in the patch failed.
-1 ❌ javac 1m 28s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-1 ❌ mvnsite 2m 32s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 shadedclient 22m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 293m 50s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
409m 13s
Reason Tests
Failed junit tests hadoop.hdfs.TestDecommissionWithBackoffMonitor
hadoop.hdfs.TestDecommission
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7320/1/artifact/out/Dockerfile
GITHUB PR #7320
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs hadolint mvnsite unit jsonlint compile cc javac
uname Linux bb5300e8b22e 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 49bf29f
Default Java Red Hat, Inc.-1.8.0_412-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7320/1/testReport/
Max. process+thread count 3780 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7320/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

slfan1989 commented Jan 24, 2025

@YanivKunda Thank you for the contribution! It can't pass the compilation successfully. We still need to continue improving it. Looking forward to the completion of this PR.

@YanivKunda
Copy link
Contributor Author

YanivKunda commented Jan 27, 2025

@slfan1989 It seems to fail on grpc-protoc generation on centos-7 -
I think the only change that can affect it is the boost upgrade (1.72 -> 1.74), but I'm actually not much of a C++/native expert.
But the question what are the different supported platforms used for?
I know the Ubuntu ones is used for CI and for local dev environment, but what are centos-7/centos-8/debian-10 used for?

Also, centos-7 is EOL for more than 6 months now:
https://www.redhat.com/en/topics/linux/centos-linux-eol
In fact, centos in general is discontinued (principally replaced by centos-stream).
In addition, debian-10 LTS ended around the same time.

Should supporting these be pursued, or are they are going to be gone any time soon?

ZanderXu and others added 20 commits March 23, 2025 21:47
@ZanderXu
HDFS-17394. [FGL] Remove unused WriteHoldCount of FSNamesystemLock (a…
3074ce0 
…pache#6571)
@ZanderXu
HDFS-17387. [FGL] Abstract the configuration locking mode (apache#6572)
37954be 
* HDFS-17387. [FGL] Abstract the configurable locking mode
@ZanderXu
HDFS-17398. [FGL] Implement the FGL lock for FSNLockManager (apache#6599
1920364 
)
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
579cba5 
…r FGL and Global lock (apache#6600)
@ZanderXu
HDFS-17390. [FGL] FSDirectory supports this fine-grained locking (apa…
8525d62 
…che#6573)
@ZanderXu
HDFS-17395. [FGL] Use FSLock to protect ErasureCodingPolicy related o…
f159fa9 
…perations (apache#6579)
@ZanderXu
HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock (a…
a6ce7f5 
…pache#6641)
@ZanderXu
HDFS-17414. [FGL] RPCs in DatanodeProtocol support fine-grained lock (a…
416aa8f 
…pache#6649)
@ZanderXu
HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-…
2b20ee3 
…grained lock (apache#6647)
@ZanderXu
HDFS-17423. [FGL] BlockManagerSafeMode supports fine-grained lock (ap…
91317e8 
…ache#6645)
@ZanderXu
HDFS-17410. [FGL] Client RPCs that changes file attributes supports f…
740e50f 
…ine-grained lock (apache#6634)
@ZanderXu
HDFS-17415. [FGL] RPCs in NamenodeProtocol support fine-grained lock (a…
10ed9f1 
…pache#6654)
@ZanderXu
HDFS-17417. [FGL] HeartbeatManager and DatanodeAdminMonitor support f…
497fcea 
…ine-grained locking (apache#6656)
@ZanderXu
HDFS-17412. [FGL] Client RPCs involving maintenance supports fine-gra…
4a828c7 
…ined lock (apache#6667)
@ZanderXu
HDFS-17420. [FGL] EditLogTailer and FSEditLogLoader support FGL (apac…
5a6e9df 
…he#6679)
@ZanderXu
HDFS-17388. [FGL] Client RPCs involving write process supports fine-g…
a75af86 
…rained lock (apache#6589)
@ZanderXu
HDFS-17389. [FGL] Client RPCs involving read process supports fine-gr…
222acab 
…ained lock (apache#6590)
@ZanderXu
HDFS-17411. [FGL] Client RPCs involving snapshot support fine-grained…
c68acb6 
… lock (apache#6714)
@ZanderXu
HDFS-17445. [FGL] some operations support fine-grained locking (apach…
0845dca 
…e#6715)
@yuanboliu
HDFS-17424. [FGL] DelegationTokenSecretManager supports fine-grained …
fa3eab2 
…lock (apache#6696)
stoty and others added 17 commits March 23, 2025 21:47
@stoty
YARN-11799. Remove PrintStream write counting from TestYarnCLI (apach…
17c895c 
…e#7518)

Contributed by Istvan Toth
@steveloughran
HADOOP-18940. [ABFS] Remove commons IOUtils.close() from AbfsOutputSt…
bbe45bd 
…ream (apache#7506)

Contributed by Mehakmeet Singh
@stoty
YARN-11797. Fix tests trying to connect to 0.0.0.0 (apache#7515) Cont…
64acd50 
…ributed by Istvan Toth.

Signed-off-by: Shilun Fan <slfan1989@apache.org>
@stoty
HADOOP-19506. Fix TestThrottledInputStream when bandwidth is equal to…
e50b4d3 
… throttle limit (apache#7517) Contributed by Istvan Toth.

Signed-off-by: Shilun Fan <slfan1989@apache.org>
@stoty
MAPREDUCE-7504. Remove terminally deprecated Thread.suspend from Test…
3f951db 
…MergeManager (apache#7519) Contributed by Istvan Toth.

Signed-off-by: Shilun Fan <slfan1989@apache.org>
@slfan1989 @cnauroth @zhtttylz
YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-r…
44acb46 
…esourcemanager Part3. (apache#7485)

YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-resourcemanager Part3.

Co-authored-by: Chris Nauroth <cnauroth@apache.org>
Co-authored-by: Hualong Zhang <hualong.z@hotmail.com>
Reviewed-by: Chris Nauroth <cnauroth@apache.org>
Reviewed-by: Hualong Zhang <hualong.z@hotmail.com>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
@stoty
HADOOP-19475. Update Boost to 1.86.0
ce87370 
Closes apache#7444

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@stoty
HADOOP-19499. Handle JDK-8225499 IpAddr.toString() format changes in …
bed06f2 
…tests

Closes apache#7502

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@stoty
HDFS-17759. Explicitly depend on jackson-core in hadoop-hdfs (apache#…
9233406 
…7508) Contributed by Istvan Toth.

Reviewed-by: PJ Fanning <fanningpj@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
@slfan1989 @zhtttylz
YARN-11787. [Federation] Enhance Exception Handling in FederationClie…
11e0778 
…ntInterceptor#forceKillApplication. (apache#7465) Contributed by Shilun Fan.

Co-authored-by: Hualong Zhang <hualong.z@hotmail.com>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
@hfutatzhanghb
HDFS-17713. [ARR] Throtting asynchronous calls for each nameservice. (a…
53e4caf 
…pache#7304). Contributed by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
@hfutatzhanghb
HDFS-17714. MockResolver#removeLocation should also remove src path. (a…
a1be50a 
…pache#7313). Contributed by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
@slfan1989
YARN-11788 - Remove unused unit tests. (apache#7476) Contributed by S…
9623330 
…hilun Fan.

Reviewed-by: Chris Nauroth <cnauroth@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
@hfutatzhanghb
HADOOP-19509. Add a config entry to make IPC.Client checkAsyncCall of…
6f7c9b5 
…f by default. (apache#7521)
@zhtttylz
HDFS-17720.[JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs-rbf Part1.
ad67a18 
Closes apache#7528

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@sjlee
HADOOP-19488 fix the temporary direction creation on Windows (apache#…
d0db7f9 
…7511)

* The Windows filesystem does not recognize
  the POSIX permissions, and it was causing the
  directory creation failure.
* This PR checks if the filesystem does not
  support POSIX permissions, it switches to using
  the user-based, ACL-based permissions that
  work on Windows.
fixed Dockerfile LegacyKeyValueFormat warnings
e1948b8
@hadoop-yetus
Copy link

hadoop-yetus commented Mar 23, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 20s #7320 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7320/2/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@YanivKunda YanivKunda closed this Mar 23, 2025
@YanivKunda YanivKunda deleted the HADOOP-19398-upgrade-Dockerfile-base-to-jammy branch March 23, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ABFS AWS build Common DistCp DYNAMOMETER HDFS Infra MapReduce Native RBF TOOLS trunk YARN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.