Skip to content

Conversation

@bharatviswa504
Copy link
Contributor

No description provided.

@bharatviswa504 bharatviswa504 requested a review from arp7 April 12, 2019 19:52
@bharatviswa504 bharatviswa504 self-assigned this Apr 12, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1058 trunk passed
+1 compile 40 trunk passed
+1 checkstyle 16 trunk passed
+1 mvnsite 28 trunk passed
+1 shadedclient 653 branch has no errors when building and testing our client artifacts.
+1 findbugs 39 trunk passed
+1 javadoc 26 trunk passed
_ Patch Compile Tests _
+1 mvninstall 35 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
+1 checkstyle 13 the patch passed
+1 mvnsite 26 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 707 patch has no errors when building and testing our client artifacts.
+1 findbugs 46 the patch passed
+1 javadoc 18 the patch passed
_ Other Tests _
+1 unit 93 server-scm in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
2955
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-735/1/artifact/out/Dockerfile
GITHUB PR #735
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4412a9f24568 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0c1fec3
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-735/1/testReport/
Max. process+thread count 468 (vs. ulimit of 5500)
modules C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-735/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504 bharatviswa504 changed the title ContainerStateMap cannot find container while allocating blocks. HDDS-1374. ContainerStateMap cannot find container while allocating blocks. Apr 12, 2019
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bharatviswa504
Copy link
Contributor Author

Test failures are not related to this patch.
I will commit this.

@bharatviswa504 bharatviswa504 merged commit 3ac3e50 into apache:trunk Apr 16, 2019
@bharatviswa504 bharatviswa504 deleted the HDDS-1374 branch April 16, 2019 20:53
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…asks for effective rate calculation

The EmbeddedTaggedRateLimiter currently uses number of tasks assigned to the currently container to calculate effective rate, which is inaccurate. With latest API refactoring, now it can take the total number of tasks.

Author: Wei Song <wsong@linkedin.com>

Reviewers: Peng Du <pdu@linkedin.com>

Closes apache#735 from weisong44/SAMZA-1959 and squashes the following commits:

ae0a0dd9 [Wei Song] SAMZA-1959: Modify EmbeddedTaggedRateLimiter to use total number of tasks for effective rate calculation
a06e8ec [Wei Song] Merge remote-tracking branch 'upstream/master'
2c679c3 [Wei Song] Merge remote-tracking branch 'upstream/master'
a56c28d [Wei Song] Merge remote-tracking branch 'upstream/master'
097958c [Wei Song] Merge remote-tracking branch 'upstream/master'
05822f0 [Wei Song] Merge remote-tracking branch 'upstream/master'
f748050 [Wei Song] Merge remote-tracking branch 'upstream/master'
7706ab1 [Wei Song] Merge remote-tracking branch 'upstream/master'
f5731b1 [Wei Song] Merge remote-tracking branch 'upstream/master'
1e5de45 [Wei Song] Merge remote-tracking branch 'upstream/master'
c85604e [Wei Song] Merge remote-tracking branch 'upstream/master'
242d844 [Wei Song] Merge remote-tracking branch 'upstream/master'
ec7d840 [Wei Song] Merge remote-tracking branch 'upstream/master'
e19b4dc [Wei Song] Merge remote-tracking branch 'upstream/master'
8ee7844 [Wei Song] Merge remote-tracking branch 'upstream/master'
1c6a2ea [Wei Song] Merge remote-tracking branch 'upstream/master'
a6c94ad [Wei Song] Merge remote-tracking branch 'upstream/master'
41299b5 [Wei Song] Merge remote-tracking branch 'upstream/master'
239a095 [Wei Song] Merge remote-tracking branch 'upstream/master'
eca0020 [Wei Song] Merge remote-tracking branch 'upstream/master'
5156239 [Wei Song] Merge remote-tracking branch 'upstream/master'
de708f5 [Wei Song] Merge remote-tracking branch 'upstream/master'
df2f8d7 [Wei Song] Merge remote-tracking branch 'upstream/master'
f28b491 [Wei Song] Merge remote-tracking branch 'upstream/master'
4782c61 [Wei Song] Merge remote-tracking branch 'upstream/master'
0440f75 [Wei Song] Merge remote-tracking branch 'upstream/master'
aae0f38 [Wei Song] Merge remote-tracking branch 'upstream/master'
a15a7c9 [Wei Song] Merge remote-tracking branch 'upstream/master'
5cbf9af [Wei Song] Merge remote-tracking branch 'upstream/master'
3f7ed71 [Wei Song] Added self to committer list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants