MAPREDUCE-7530. MR AM REST API backward compatibility with Jersey1#8247
Draft
K0K0V0K wants to merge 1 commit intoapache:trunkfrom
Draft
MAPREDUCE-7530. MR AM REST API backward compatibility with Jersey1#8247K0K0V0K wants to merge 1 commit intoapache:trunkfrom
K0K0V0K wants to merge 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
| Annotation[] annotations, MediaType mediaType, | ||
| MultivaluedMap<String, String> httpHeaders, | ||
| Unmarshaller unmarshaller) throws JAXBException { | ||
| LOG.trace("ExcludeRootJSONProvider preReadFrom with {}", type); |
Contributor
There was a problem hiding this comment.
Will we need these log for production as well?
Or you have not deleted it from your testing?
Contributor
Author
There was a problem hiding this comment.
I think this can be useful with trace level
Contributor
There was a problem hiding this comment.
You are right. My bad, it is a low level than DEBUG.
Contributor
Hean-Chhinling
left a comment
There was a problem hiding this comment.
Thank you @K0K0V0K for working on this.
I only have a small comment otherwise it all looks good to me
Comment on lines
38
to
57
| @@ -48,38 +55,31 @@ | |||
| import org.apache.hadoop.mapreduce.v2.app.webapp.dao.TaskCounterInfo; | |||
| import org.apache.hadoop.mapreduce.v2.app.webapp.dao.TaskInfo; | |||
| import org.apache.hadoop.mapreduce.v2.app.webapp.dao.TasksInfo; | |||
Contributor
There was a problem hiding this comment.
A lot of these import statements are not used anymore.
I think it would be nice to remove them
p-szucs
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
We can not get metrics for running MR job via proxy.
Example call:
http://{{RM}}:8088/proxy/application_1770709887971_0014/ws/v1/mapreduce/jobs/job_1770709887971_0014/counters
Results:
404
Seems like we have to use moxy here also
How was this patch tested?
I manually tried some MR job, and I could access the UI
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
No AI tool was used