HADOOP-18898. Add argLine to maven-failsafe-plugin and fix duplicate argLine in hadoop-tos#8253
Open
eciuca wants to merge 2 commits intoapache:trunkfrom
Open
HADOOP-18898. Add argLine to maven-failsafe-plugin and fix duplicate argLine in hadoop-tos#8253eciuca wants to merge 2 commits intoapache:trunkfrom
eciuca wants to merge 2 commits intoapache:trunkfrom
Conversation
…argLine in hadoop-tos.
The maven-failsafe-plugin in hadoop-project/pom.xml had no argLine
configuration, so integration tests forked by failsafe did not receive
the --add-opens JVM options needed for Java 17+ compatibility.
Additionally, hadoop-tos/pom.xml had two <argLine> elements in the same
surefire <configuration> block. Since argLine is a scalar String parameter,
the second element (-Xmx2048m) silently overwrote the first one that
included ${maven-surefire-plugin.argLine}, causing all JPMS options to be
lost in forked test JVMs.
Contains content generated by Claude Code.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
💔 -1 overall
This message was automatically generated. |
The io.github.ascopes:protobuf-maven-plugin 5.0.0 removed deprecated parameter aliases: protocVersion was renamed to protoc, and binaryMavenPlugins was replaced by the unified plugins element with kind="binary-maven". Update the configuration to use the current parameter names so protoc can be resolved. Contains content generated by Claude Code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
💔 -1 overall
This message was automatically generated. |
Author
|
Thanks for the review, @hadoop-yetus. Re: trunk failures (mvninstall, compile, mvnsite, javadoc): These all fail on trunk due to the broken Re: javadoc warnings (26 new): These are pre-existing missing-comment warnings in Re: test4tests: This PR only modifies Maven |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Child JVMs spawned by Maven's failsafe plugin during integration tests do not receive the
--add-opensJVM options needed for Java 17+ compatibility.Three fixes:
hadoop-project/pom.xml— Added<argLine>${maven-surefire-plugin.argLine}</argLine>to themaven-failsafe-pluginconfiguration in<pluginManagement>. This ensures all failsafe usages across the project (hadoop-aws, hadoop-azure, hadoop-gcp, hadoop-client-integration-tests) inherit the--add-opensoptions by default, matching the existing surefire configuration.hadoop-cloud-storage-project/hadoop-tos/pom.xml— Fixed a bug where two<argLine>elements existed in the same surefire<configuration>block. SinceargLineis a scalarStringparameter, the second element (-Xmx2048m) silently overwrote the first one that included${maven-surefire-plugin.argLine}, causing all JPMS options to be lost in 8 forked test JVMs. Merged into a single<argLine>${maven-surefire-plugin.argLine} -Xmx2048m</argLine>.hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml— Fixedio.github.ascopes:protobuf-maven-pluginv5.0.0 configuration that used removed parameter aliases.protocVersionwas renamed toprotocandbinaryMavenPlugins/binaryMavenPluginwas replaced by the unifiedplugins/plugin kind="binary-maven"structure. Without this fix the build fails with:The parameters 'protoc' for goal io.github.ascopes:protobuf-maven-plugin:5.0.0:generate are missing or invalid.How was this patch tested?
maven-failsafe-plugininhadoop-project/pom.xmlpreviously had noargLineconfiguration (only version was set in<pluginManagement>)argLineexplicitly with${maven-surefire-plugin.argLine}, but the sequential-tests profiles and hadoop-client-integration-tests did notStringparameters uses last-element-wins semantics for duplicate elementsFor code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
https://www.apache.org/legal/generative-tooling.html