Skip to content

HADOOP-19829. Bump lz4-java 1.10.4#8294

Open
pan3793 wants to merge 1 commit intoapache:trunkfrom
pan3793:HADOOP-19829
Open

HADOOP-19829. Bump lz4-java 1.10.4#8294
pan3793 wants to merge 1 commit intoapache:trunkfrom
pan3793:HADOOP-19829

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Mar 3, 2026

Description of PR

HADOOP-19747 switched lz4-java to at.yawk.lz4 group for security reason, but it unintentionally introduced performance regression.

https://github.com/yawkat/lz4-java/releases/tag/v1.10.4

These changes attempt to fix the native performance regression in 1.9+. They should have no functional or security impact.

How was this patch tested?

See the benchmark reports in Celeborn and Spark projects

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (HADOOP-19829)?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

No AI usage.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 21s #8294 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #8294
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8294/1/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@pan3793
Copy link
Member Author

pan3793 commented Mar 3, 2026

To avoid perf regression, please consider including this in 3.5.0

cc @cnauroth @aajisaka @slfan1989 @pjfanning

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to include in 3.5.0

@slfan1989
Copy link
Contributor

LGTM, merging the PR requires waiting for the +1 result from Yetus compilation.

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I'll plan to include in 3.5.0. Thanks @pan3793 !

@aajisaka
Copy link
Member

aajisaka commented Mar 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants