HADOOP-19868: ci: add comments from security review of new actions#8450
Open
ajfabbri wants to merge 1 commit intoapache:trunkfrom
Open
HADOOP-19868: ci: add comments from security review of new actions#8450ajfabbri wants to merge 1 commit intoapache:trunkfrom
ajfabbri wants to merge 1 commit intoapache:trunkfrom
Conversation
e435b8d to
e823d4f
Compare
4 tasks
Member
|
@ajfabbri, thanks for the follow-up. this is the first PR from the forked repo to verify that workflow, and it's good to see it works by design. Could you convert the Jira ticket to sub-task of HADOOP-19857 so we can collect all GitHub Actions work? And I just opened another PR (#8451) as promised - leverage cache to speed up the image building. e.g.,
I guess you also want to add such comments to those new YAML files |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
No code change; comments only.
Following up on HADOOP-19858, this PR adds
# Security:comments to add to ourgithub actions to explain why each workflow is safe.
How was this patch tested?
Comments only, but CodeQL scanning is now enabled for changes within the
.githubdirectory.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html