HDFS-17917. Fix empty block list enqueue in markedDeleteQueue#8475
Open
magnuma3 wants to merge 3 commits intoapache:trunkfrom
Open
HDFS-17917. Fix empty block list enqueue in markedDeleteQueue#8475magnuma3 wants to merge 3 commits intoapache:trunkfrom
magnuma3 wants to merge 3 commits intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
added 2 commits
May 8, 2026 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When deleting empty directory, empty list is added to markedDeleteQueue.
I think this is unnecessary. and markedDeleteQueue.size() is O(n) operation, so it is costly.
How was this patch tested?
unit test
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html