Skip to content

HADOOP-19882. Change cmake_minimum_required to version 3.5#8477

Merged
pan3793 merged 1 commit intoapache:trunkfrom
pan3793:HADOOP-19882
May 8, 2026
Merged

HADOOP-19882. Change cmake_minimum_required to version 3.5#8477
pan3793 merged 1 commit intoapache:trunkfrom
pan3793:HADOOP-19882

Conversation

@pan3793
Copy link
Copy Markdown
Member

@pan3793 pan3793 commented May 7, 2026

Description of PR

Modern OS, like Ubuntu 26.04, which bundles CMake 4.x, remove support for compatibility with versions of CMake older than 3.5

https://cmake.org/cmake/help/latest/release/4.0.html

Deprecated and Removed Features

  • Compatibility with versions of CMake older than 3.5 has been removed.

CMake 3.5 was released on April 28, 2016, which is quite an old version, the change does not affect the current supported OS because they already bundle CMake 3.5+

  • Rocky Linux 8: CMake 3.26.5
  • Debian 12: CMake 3.25.1-1
  • Debian 13: CMake 3.31.6-2
  • Ubuntu 24.04: CMake 3.28.3

How was this patch tested?

Pass GHA.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (HADOOP-19882)?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

No AI usage.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 1m 59s Maven dependency ordering for branch
+1 💚 mvninstall 26m 56s trunk passed
+1 💚 compile 9m 46s trunk passed with JDK Red Hat, Inc.-21.0.11+10-LTS
+1 💚 compile 10m 1s trunk passed with JDK Red Hat, Inc.-17.0.19+10-LTS
+1 💚 mvnsite 7m 11s trunk passed
+1 💚 shadedclient 73m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 38s Maven dependency ordering for patch
+1 💚 mvninstall 5m 9s the patch passed
+1 💚 compile 8m 52s the patch passed with JDK Red Hat, Inc.-21.0.11+10-LTS
+1 💚 cc 8m 52s the patch passed
+1 💚 javac 8m 52s the patch passed
+1 💚 compile 9m 55s the patch passed with JDK Red Hat, Inc.-17.0.19+10-LTS
+1 💚 cc 9m 55s the patch passed
+1 💚 javac 9m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 7m 6s the patch passed
+1 💚 shadedclient 24m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 15s hadoop-common in the patch passed.
+1 💚 unit 7m 5s hadoop-hdfs-native-client in the patch passed.
+1 💚 unit 23m 52s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 7m 52s hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚 unit 1m 22s hadoop-pipes in the patch passed.
+1 💚 asflicense 1m 31s The patch does not generate ASF License warnings.
191m 55s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/artifact/out/Dockerfile
GITHUB PR #8477
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname Linux 1b27992c7506 5.15.0-141-generic #151-Ubuntu SMP Sun May 18 21:35:19 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bab9563
Default Java Red Hat, Inc.-17.0.19+10-LTS
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-21.0.11.0.10-1.el8_10.x86_64:Red Hat, Inc.-21.0.11+10-LTS /usr/lib/jvm/java-17-openjdk-17.0.19.0.10-1.el8_10.x86_64:Red Hat, Inc.-17.0.19+10-LTS
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/testReport/
Max. process+thread count 3159 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-tools/hadoop-pipes U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/console
versions git=2.43.7 maven=3.9.11
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 19m 29s trunk passed
+1 💚 compile 8m 27s trunk passed
+1 💚 mvnsite 3m 24s trunk passed
+1 💚 shadedclient 48m 5s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 8m 5s the patch passed
+1 💚 cc 8m 5s the patch passed
+1 💚 javac 8m 5s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 3m 25s the patch passed
+1 💚 shadedclient 19m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 46s hadoop-common in the patch passed.
+1 💚 unit 6m 10s hadoop-hdfs-native-client in the patch passed.
-1 ❌ unit 22m 56s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 6m 46s hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚 unit 0m 35s hadoop-pipes in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
143m 15s
Reason Tests
Failed junit tests hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor
TEST-cetest
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/artifact/out/Dockerfile
GITHUB PR #8477
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname Linux 798344519a51 5.15.0-141-generic #151-Ubuntu SMP Sun May 18 21:35:19 UTC 2025 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bab9563
Default Java Debian-25.0.3+9-2-deb13u1-Debian
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/testReport/
Max. process+thread count 1250 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-tools/hadoop-pipes U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/console
versions git=2.47.3 maven=3.9.11
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 20m 24s trunk passed
+1 💚 compile 8m 29s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 8m 46s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 mvnsite 3m 31s trunk passed
+1 💚 shadedclient 57m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 47s the patch passed
+1 💚 compile 8m 6s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 cc 8m 6s the patch passed
+1 💚 javac 8m 6s the patch passed
+1 💚 compile 8m 43s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 cc 8m 43s the patch passed
+1 💚 javac 8m 43s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 3m 24s the patch passed
+1 💚 shadedclient 18m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 38s hadoop-common in the patch passed.
+1 💚 unit 6m 12s hadoop-hdfs-native-client in the patch passed.
+1 💚 unit 22m 54s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 6m 58s hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚 unit 0m 35s hadoop-pipes in the patch passed.
+1 💚 asflicense 0m 44s The patch does not generate ASF License warnings.
153m 56s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/artifact/out/Dockerfile
GITHUB PR #8477
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname Linux d1ef3b069811 5.15.0-141-generic #151-Ubuntu SMP Sun May 18 21:35:19 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bab9563
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/testReport/
Max. process+thread count 1283 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-tools/hadoop-pipes U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8477/1/console
versions git=2.43.0 maven=3.9.11
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@pan3793 pan3793 merged commit add0097 into apache:trunk May 8, 2026
3 of 5 checks passed
pan3793 added a commit that referenced this pull request May 8, 2026
Reviewed-by: Shilun Fan <slfan1989@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793
Copy link
Copy Markdown
Member Author

pan3793 commented May 8, 2026

thanks, merged to trunk/branch-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants