Skip to content

HADOOP-19899. Fix sleep time in RetryInvocationHandler#8507

Merged
adoroszlai merged 1 commit into
apache:trunkfrom
adoroszlai:HADOOP-19899
May 24, 2026
Merged

HADOOP-19899. Fix sleep time in RetryInvocationHandler#8507
adoroszlai merged 1 commit into
apache:trunkfrom
adoroszlai:HADOOP-19899

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Sleep period in RetryInvocationHandler should be waitTime, not delay.

  1. RetryInfo.retryTime is calculated when it is created:
    this.delay = delay;
    this.retryTime = Time.monotonicNow() + delay;
  2. waitTime is calculated before sleep as:
    synchronized Long getWaitTime(final long now) {
    return retryInfo == null? null: retryInfo.retryTime - now;
  3. but then original RetryInfo.delay is used for actual sleep time:
    final Long waitTime = getWaitTime(Time.monotonicNow());
    LOG.trace("#{} processRetryInfo: retryInfo={}, waitTime={}",
    callId, retryInfo, waitTime);
    if (waitTime != null && waitTime > 0) {
    try {
    Thread.sleep(retryInfo.delay);

https://issues.apache.org/jira/browse/HADOOP-19899

How was this patch tested?

https://github.com/adoroszlai/hadoop/actions/runs/26225351328

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 24s trunk passed
+1 💚 compile 10m 31s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 compile 10m 52s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 checkstyle 0m 48s trunk passed
+1 💚 mvnsite 1m 10s trunk passed
+1 💚 javadoc 0m 47s trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 46s trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 1m 51s trunk passed
+1 💚 shadedclient 22m 18s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 10m 28s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javac 10m 28s the patch passed
+1 💚 compile 10m 58s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 javac 10m 58s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 0m 48s the patch passed
+1 💚 mvnsite 1m 7s the patch passed
+1 💚 javadoc 0m 47s the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚 javadoc 0m 48s the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚 spotbugs 2m 6s the patch passed
+1 💚 shadedclient 21m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 9s hadoop-common in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
149m 53s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8507/1/artifact/out/Dockerfile
GITHUB PR #8507
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 90b663f3aa37 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 14f5a12
Default Java Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8507/1/testReport/
Max. process+thread count 3118 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8507/1/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@adoroszlai adoroszlai merged commit 46d02ca into apache:trunk May 24, 2026
3 of 5 checks passed
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @slfan1989, @ZanderXu for the review.

@adoroszlai adoroszlai deleted the HADOOP-19899 branch May 24, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants