HADOOP-19899. Fix sleep time in RetryInvocationHandler#8507
Merged
Conversation
slfan1989
approved these changes
May 22, 2026
ZanderXu
approved these changes
May 22, 2026
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Thanks @slfan1989, @ZanderXu for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sleep period in
RetryInvocationHandlershould bewaitTime, notdelay.RetryInfo.retryTimeis calculated when it is created:hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
Lines 252 to 253 in 71d216d
waitTimeis calculated beforesleepas:hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
Lines 84 to 85 in 71d216d
RetryInfo.delayis used for actual sleep time:hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
Lines 130 to 135 in 71d216d
https://issues.apache.org/jira/browse/HADOOP-19899
How was this patch tested?
https://github.com/adoroszlai/hadoop/actions/runs/26225351328