HADOOP-19900. EC write can fail with ArrayIndexOutOfBoundsException due to CoderUtil emptyChunk resize race#8518
Merged
Merged
Conversation
…ue to CoderUtil emptyChunk resize race
Generated-by: Claude Code (Opus 4.7)
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Thanks @ZanderXu for reviewing this! Merging this as yetus looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HADOOP-19900
Contains content generated by Claude Code (Opus 4.7)
Description of PR
Fix a race in
CoderUtil.getEmptyChunk()that can cause EC writes to fail withArrayIndexOutOfBoundsExceptionduring parity encoding.This can be hit when multiple EC key output streams in the same client JVM use the Java raw EC encoder concurrently with different encode/reset lengths. Each
ECKeyOutputStreamhas its own encoder, but all Java encoders share the staticCoderUtil.emptyChunkcache. If native ISA-L is unavailable or not selected, the JavaRSRawEncoderclears parity output buffers throughCoderUtil.resetOutputBuffers(). Under concurrent close/flush paths, especially with partial final stripes of different sizes, one stream can grow the shared zero buffer for a larger encode while another smaller encode races and shrinks it, causing the larger encode’s laterSystem.arraycopy()to throwArrayIndexOutOfBoundsException.For more details, see apache/ozone#10324
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html